search

sunpy / sunpy-soar

A sunpy plugin for accessing data in the Solar Orbiter Archive (SOAR).
https://docs.sunpy.org/projects/soar/
BSD 2-Clause "Simplified" License
17 stars 11 forks source link

fov table joins added #143

Open NucleonGodX opened 1 month ago

NucleonGodX commented 1 month ago

To implement functionality for plotting curves using Field of View (FoV) values available in SOAR, we needed to first add support for these tables in sunpy-soar. This PR introduces that necessary support for FoV tables.

nabobalis commented 1 month ago

Can we make FOV opt in?

NucleonGodX commented 1 month ago

Can we make FOV opt in?

Can you explain what you mean by this?

NucleonGodX commented 1 month ago

I've tried to add a functionality, FOV can be passed in the search query with "earth" and "solar" values which would give coordinates with respect to that, if there is no FOV in search query it returns the normal table, if the user passes FOV in search query, depending on the value of it being solar or earth, the user will get all four coordinates.

nabobalis commented 1 month ago

Can we make FOV opt in?

Can you explain what you mean by this?

By making it a new attribute a user can add to the query instead of being done all the time.

nabobalis commented 1 month ago

We should create the example as well. Might as well go all in.

NucleonGodX commented 1 month ago

We should create the example as well. Might as well go all in.

Alrighty!

NucleonGodX commented 1 month ago

Looks like the doc test is failing, I'll fix it.