search

sunpy / sunpy

SunPy - Python for Solar Physics
http://www.sunpy.org
BSD 2-Clause "Simplified" License
917 stars 588 forks source link

Upstream longitude equality helper to astropy #3821

Open dstansby opened 4 years ago

dstansby commented 4 years ago

https://github.com/sunpy/sunpy/pull/3804 probably belongs in astropy, not SunPy; fine to have it here for now, but we should really send it upstream as it's astropy.coordinates, and not sunpy, specific.

akash5100 commented 2 years ago

Hi @dstansby, @nabobalis sir, I am interested in contributing to SunPy, what are the changes required to close this issue, any pointers to what I have to do? What do you mean by:

but we should really send it upstream

nabobalis commented 2 years ago

Hi @dstansby, @nabobalis sir, I am interested in contributing to SunPy, what are the changes required to close this issue, any pointers to what I have to do? What do you mean by:

but we should really send it upstream

Hello @akash5100, this issue needs someone to copy the function from #3804 and submit it to astropy (this is what is meant by sending it upstream).

akash5100 commented 2 years ago

Hi @dstansby, @nabobalis sir, I am interested in contributing to SunPy, what are the changes required to close this issue, any pointers to what I have to do? What do you mean by:

but we should really send it upstream

Hello @akash5100, this issue needs someone to copy the function from #3804 and submit it to astropy (this is what is meant by sending it upstream).

After submitting, remove it from the sunpy?

nabobalis commented 2 years ago

After submitting, remove it from the sunpy?

Not until it makes it into a release of astropy we can use. Before that, we will have to keep it in sunpy.

ayshih commented 2 years ago

I think you'll want to propose adding it to astropy/coordinates/tests/helper.py

Prtm2110 commented 3 months ago

Shall I create an issue and PR addressing this in astropy?

nabobalis commented 3 months ago

Shall I create an issue and PR addressing this in astropy?

It's worth asking and seeing if they will take it