supabase-community / postgrest-csharp

A C# Client library for Postgrest

https://supabase-community.github.io/postgrest-csharp/api/Postgrest.html

MIT License

117 stars 23 forks source link

fix: #85 #86

Closed hunsra closed 8 months ago

hunsra commented 8 months ago

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

85

What is the new behavior?

Modified Postgrest.Table.GenerateUrl() to produce a single order query parameter with comma-separated expressions for each chained .Order() method rather than producing a separate order query parameter for each.

Additional context

The changes resolved the issue #85, although its uncertain whether the changes are correctly made for ordering by foreign table columns.

acupofjose commented 8 months ago

Wonderful, thanks for taking the time @hunsra! Just added a quick test to verify the functionality works as expected and added a variable to clarify a rather long ternary operation.

Appreciate you taking the time! I'll add this fix into the next minor release.

hunsra commented 8 months ago

Thanks @acupofjose. Happy to contribute.