supabase-community / storage-swift

Swift client library to interact with Supabase Storage

MIT License

26 stars 11 forks source link

JSON decoding issues #7

Open NoahKamara opened 1 year ago

NoahKamara commented 1 year ago

Bug report

I've noticed that JSON decoding has some issues (missing keys, optionals not handled) and that you're not using Codable to decode. Is there a particular reason for that?

As far as I'm aware, Codable is available on linux too according to this PR

The Bucket Model for example is almost entirely optional, which is not handled (maybe due to code generation from javascript?)

If there is no reason against implementation with Codable, I'd be up to doing that :)

grdsdev commented 1 year ago

Hi @NoahKamara this lib was first implemented without support for Codable (don't know why). Migrate to Codable is in the roadmap, feel free to PR a change.

maail commented 1 year ago

Noting that PR for this issue has been raised here https://github.com/supabase-community/storage-swift/pull/9