feat: add option to disable magic links

supabase / auth

A JWT based API for managing users and issuing JWT tokens

https://supabase.com/docs/guides/auth

MIT License

1.56k stars 376 forks source link

feat: add option to disable magic links #1756

Closed hf closed 2 months ago

hf commented 2 months ago

Adds an option to disable magic links, as they are more prone to email sending abuse than other email authentication methods.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10664277986

Details

1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.005%) to 57.862%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/api/magic_link.go	1	3	33.33%
<!--	Total:	1	3	33.33%	-->

Totals
Change from base Build 10663558264:	-0.005%
Covered Lines:	9126
Relevant Lines:	15772

💛 - Coveralls

hf commented 2 months ago

Generate link is used to generate a link that is sent separately from the Auth server, so that's fine. This only blocks magic links generated from the endpoint.

J0 commented 2 months ago

Yup, that makes sense - let's document that the toggle only blocks magic links generated from the endpoint then.