coveralls
commented
2 months ago Pull Request Test Coverage Report for Build 10830767253
Details
- 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
- 3 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.02%) to 57.882%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| internal/api/admin.go | 4 | 5 | 80.0% | ||
| <!-- | Total: | 8 | 9 | 88.89% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| internal/api/admin.go | 3 | 65.75% | ||
| <!-- | Total: | 3 | --> |
| Totals | |
|---|---|
| Change from base Build 10813800948: | -0.02% |
| Covered Lines: | 9135 |
| Relevant Lines: | 15782 |
What kind of change does this PR introduce?
Update admin MFA methods to allow an admin to update a phone factor's phone number. Also disallows and removes factor type as an updatable field. Having the factor type field is redundant as it previously allowed for update of only one factor type (TOTP).