Closed avallete closed 3 weeks ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
internal/debug/postgres.go | 3 | 64.86% | ||
internal/gen/keys/keys.go | 5 | 12.9% | ||
<!-- | Total: | 8 | --> |
Totals | |
---|---|
Change from base Build 11677870651: | -0.06% |
Covered Lines: | 6372 |
Relevant Lines: | 10660 |
The other change that we want to do on the worker side is to trigger SIGUP on the database to apply the new config when not restarting https://supabase.slack.com/archives/C02FHG9QQAF/p1729925142614479?thread_ts=1728485737.099679&cid=C02FHG9QQAF
What kind of change does this PR introduce?
Following: https://github.com/supabase/infrastructure/pull/20462
Let the api decide if the service restart is necessary.
caution Deduplicating the logic remove our ability to log a message to the user but since we didn't allowed to act on it (agree / refute) I think it's alright to let the API be the source of truth.
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.