search

supabase / supabase-flutter

Flutter integration for Supabase. This package makes it simple for developers to build secure and scalable products.
https://supabase.com/
MIT License
741 stars 183 forks source link

signInWithOtp does not return OTP type, making it unclear whether to use sign-up confirmation or magic link flow #1078

Open bennajah opened 2 weeks ago

bennajah commented 2 weeks ago

Describe the bug The signInWithOtp method does not return any indication of which OTP type (sign-up confirmation or magic link) was sent. This makes it unclear which flow to follow in the verifyOtp method, as the OTP type depends on whether the user's email is verified.

To Reproduce Steps to reproduce the behavior:

  1. Call signInWithOtp with an email that may or may not be verified.
  2. Observe that the method returns null, with no indication of whether a sign-up confirmation or a magic link email was sent.

Expected behavior I expect signInWithOtp to return an indicator of the OTP type (e.g.,the email is verified, sign-up confirmation or magic link) so that I can handle the appropriate verification flow in the verifyOtp method.

Screenshots If applicable, add screenshots to help explain your problem.

Version (please complete the following information): supabase_flutter 2.8.0 supabase 2.5.0 functions_client 2.4.0 gotrue 2.10.0 postgrest 2.3.0 realtime_client 2.4.0 storage_client 2.2.0

Additional context This enhancement would allow developers to handle OTP verification flows more accurately by knowing which type of OTP was sent.

khalidouaadou1 commented 2 weeks ago

The SignInWithOtp method can be used for both sign-in and sign-up, while verifyOtp handles the OTP verification for SignInWithOtp.

This approach supports different OtpType values:

OtpType.signup: for cases where the email does not exist or is unverified.

OtpType.magiclink: for cases where the email is already verified.

Because of this, it’s not always clear if SignInWithOtp is being used for sign-in or sign-up.