search

supabase / supabase-flutter

Flutter integration for Supabase. This package makes it simple for developers to build secure and scalable products.
https://supabase.com/
MIT License
745 stars 184 forks source link

chore: Support mime 2.0.0 #1079

Closed Vinzent03 closed 2 weeks ago

Vinzent03 commented 3 weeks ago

What kind of change does this PR introduce?

package upgrade

What is the current behavior?

mime 2.0.0 is not supported

What is the new behavior?

Support 1.2.0 and 2.0.0

Additional context

mime changelog We don't use that method so the update doesn't matter.

close #1074

rickypid commented 2 weeks ago

@dshukertjr,

when will it be available on pub.dev?

Thank you very much.

talamaska commented 1 week ago

When we can expect this fix to be released. It's not in supabase_flutter 2.8.1, and the version of the storage_client is not updated and published with this fix?

Vinzent03 commented 1 week ago

This change is indeed released with supabase_flutter 2.8.1. To actually upgrade to mime 2.0 You have to run pub upgrade, because we still support 1.0.0.

rickypid commented 1 week ago

@Vinzent03

image

Vinzent03 commented 1 week ago

I'm sorry and seems like you are right. The release script from melos didn't pick up the changes in storage_client and no new version got released. @dshukertjr Could you try to release a new version with the version bump of mime.

rickypid commented 1 week ago

@Vinzent03

don't worry, no problem. I'm waiting for the next release. one of the main problems is related to the score that is lowered by the dependencies not updated

talamaska commented 1 week ago

mime 2.0 has a breaking change of returning null for unknown mime type. It's not just a version update for the sake of a pub score. I think you are already handling having mime type being nullable.

rickypid commented 1 week ago

In my case I have no issues related to that method, regarding this PR @Vinzent03 indicated that it is not impactful on this package.