search

supercargo / guice-persist-jooq

Guice-persist extension for using jOOQ based persistence layer
Apache License 2.0
22 stars 9 forks source link

JooqPersistService will no longer begin a unit of work when providing a DSLContext #10

Closed GuiSim closed 6 years ago

GuiSim commented 6 years ago

Fixes https://github.com/supercargo/guice-persist-jooq/issues/9

I still think that there are no scenarios that can justify not calling begin() explicitly (through PersistFilter, unitOfWork.begin() or @Transactional)

This is why I decided not to add a fallback to this behavior.

Let me know what you think. If this is merged, I would advise that a new major version is deployed, so that the change is more "apparent", just in case a user relied on this. Either way, with this new fail fast approach users that are not using it "correctly" will realize it very quickly.

supercargo commented 6 years ago

I think this will warrant a 1.0.0 release given the breaking nature. Given that, I'd like to make additional (potentially) breaking changes at the same time (not in this PR, just before a release).

If you don't mind waiting for the 1.0.0 release I can merge this as is.

GuiSim commented 6 years ago

@supercargo Awesome!

Can we just get a -RC or maybe a 1.0.0-beta so we can already switch to this new code? If not, we'll deploy one internally.

Thanks!

GuiSim commented 6 years ago

Thanks! I'm looking forward to your other changes too :)