search

supercargo / guice-persist-jooq

Guice-persist extension for using jOOQ based persistence layer
Apache License 2.0
22 stars 9 forks source link

Add support for pooled connections + cleanup #17

Closed apptio-msobala closed 2 years ago

apptio-msobala commented 2 years ago

Fixes #16.

supercargo commented 2 years ago

Awesome, thanks for the PR @apptio-msobala! This doesn't build as-is for me because it looks like jOOQ 3.15.0 requires Java 11 (at least for the OSS license). I can build against 3.14 while without dropping Java 8 support, and the jOOQ API seems compatible. Since jOOQ is a provided dependency I don't believe there should be any issues if consumers want to use 3.15 or higher, but not sure if the modularization added in 3.15 causes any issues.

Other than that this overall looks good. I'll probably bump to v2.0 given the major changes in Java and library versions.

apptio-msobala commented 2 years ago

@supercargo do you want to change it yourself?

supercargo commented 2 years ago

It's very minor, I already have a branch off your branch with that change which I pushed for the sake of tagging/releasing. It is (or will shortly be) available at

<dependency>
  <groupId>com.adamlewis</groupId>
  <artifactId>guice-persist-jooq</artifactId>
  <version>2.0.0-beta-1</version>
</dependency>

@apptio-msobala Could you try out 2.0.0-beta-1 and, if that works for you, I can merge your PR and my changes on top and re-publish without the beta designation.

apptio-msobala commented 2 years ago

@supercargo works as expected. Tested using both integration tests of transactions and in a running application.

apptio-msobala commented 2 years ago

@supercargo bump

supercargo commented 2 years ago

Thanks for your contributions @apptio-msobala! v2.0.0 is released and will become available as maven central mirrors come up to date.