Added Transactional annotation cache

supercargo / guice-persist-jooq

Guice-persist extension for using jOOQ based persistence layer

Apache License 2.0

22 stars 9 forks source link

Added Transactional annotation cache #6

Closed roded closed 7 years ago

roded commented 7 years ago

Hi, Comments welcome. The default annotation is not included in the cache. (Not sure when the interceptor is activated for a non-annotated method though)

supercargo commented 7 years ago

Overall I think this looks good. I'm curious if you've hit actual performance issues which improve with this change? If this is performance critical for you, I'm wondering if it would be worth skipping the containsKey call and just checking the result of get for null.

roded commented 7 years ago

You're right. See update. Probably too small of a change to notice. It's just an easy fix to my DB call stack which caught my eye.