supercollider / sc3-plugins

Community plugins for SuperCollider
https://supercollider.github.io/sc3-plugins/
GNU General Public License v2.0
449 stars 122 forks source link

Greyhole and JPverb RTAlloc safety #133

Closed nhthn closed 6 years ago

nhthn commented 7 years ago

A few people have experienced crashes with these two UGens. The help files correctly suggest increasing the server real-time memory size to 2^18 kb (around 260 mb), which fixes the problem.

The server crash is entirely preventable, by adding a check to see if RTAlloc returned NULL and gracefully exiting. However, both these UGens are generated by FAUST, so this is really an upstream issue.

vivid-synth commented 7 years ago

To the Faust castle!

nhthn commented 7 years ago

Alright, looks like this has been fixed upstream. The remaining steps are to recompile the FAUST code and ensure that nothing has changed in the process. (There may have been a behavior change in FAUST since the last time these two ugens were compiled.)

Since I'm too lazy to compile FAUST and I can't develop sc3-plugins anyway, this is a job for someone else :)

muellmusik commented 7 years ago

File an issue with Faust. The generated code should follow best practice.

On 15 Dec 2016, at 21:37, vivid-synth notifications@github.com wrote:

To the Faust castle!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

LFSaw commented 7 years ago

I fixed the dsp files, need some help for the compilation (see #142 )

LFSaw commented 7 years ago

I don't know where to address this, the plugins compile fine but the server crashes immediately while booting. I assume this is due to an increased amount of memory allocated (?) since smaller FAUST plugins such as

import("stdfaust.lib");

process = _,_;

compile and run just fine.

Help much appreciated.

LFSaw commented 7 years ago

for the moment, I put the complete (and compiling in faust and faustlive) dsp files here: https://gist.github.com/LFSaw/17a6125b113cd420eaed104a10653b20

LFSaw commented 7 years ago

According to "the FAUST castle" ((c) @vivid-synth), the fix for FAUST RTAlloc safety is covered with https://github.com/grame-cncm/faust/issues/12.

LFSaw commented 7 years ago

please review

jbtwh commented 6 years ago

Greyhole and JPverb are crashing scsynth for me using basic examples from doc. sc version 3.8.0 windows 7

nhthn commented 6 years ago

@jbtwh this has been fixed in 3.9. the workaround for 3.8 is to set this in the server options before booting:

s.options.memSize_(2**18)

the units are kilobytes, so this is around 260MB.

totalgee commented 6 years ago

I know this is closed/solved for the future, and indeed I've confirmed it does work in 3.9-beta1, but just FYI unfortunately the "workaround" does not work with JPverb in the released v3.8.0 Windows (VS 64-bit version); even setting the memSize to 512MB didn't work. I think the workaround only works with the 32-bit version.

LFSaw commented 6 years ago

please open a new issue for this.

On 07. Dec 2017, at 17:49, Glen Fraser notifications@github.com wrote:

I know this is closed/solved for the future, and indeed I've confirmed it does work in 3.9-beta1, but just FYI unfortunately the "workaround" does not work with JPverb in the released v3.8.0 Windows (VS 64-bit version); even setting the memSize to 512MB didn't work. I think the workaround only works with the 32-bit version.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.