search

supercollider / scvim

Vim plugin for SuperCollider
GNU General Public License v3.0
121 stars 28 forks source link

[WIP] Filetype plugin refactor #40

Closed davidgranstrom closed 5 years ago

davidgranstrom commented 6 years ago

Hi all,

I started to refactor this plugin a while back with the aim of making it a "true" filetype plugin and to optimize performance/load time where I could. I haven't worked on it for a while now but I thought I should post what I have done so far in case someone would like to comment on this or pick it up from here.

The thing I didn't get around to do was to convert the mappings to <Plug> mappings instead of using autocommands.

This PR also introduces a new variable g:scvim_no_mappings which when toggled disables the default scvim key mappings. I find this useful as I have my own mappings, and maybe others will too? This change should probably go in a separate PR though, I can remove it and submit another PR if anyone is interested in this.

Let me know if you think this is a step in the right direction, I could maybe find some time in the near future to wrap this up!

wsdjeg commented 5 years ago

What is the status of this PR, is it ready to be merged? I am author of SpaceVim, and I am going to add supercollider support in spacevim. but the current implementation break my key bindings.

mossheim commented 5 years ago

@wsdjeg as you can see, this PR isn't being actively worked on

capocasa commented 5 years ago

This is really cool!

A pull request is however not the appropriate mechanism for explorative programming, pull requests are for requesting merges of code that is ready for prime time. I would suggest to call for collaboration on the SC mailing lists.