search

superduper / BrightnessMenulet

BrightnessMenulet is an Mac OS X app that allows you to control display brightness via DDC/CI protocol
433 stars 91 forks source link

ddcctl submodule #71

Open Kalvin126 opened 7 years ago

Kalvin126 commented 7 years ago

Hey @superduper and all watching this repo,

Not sure how I did not notice my fork got pulled into this base long ago. I have been busy with post-college iOS work. I finally got around to integrating ddcctl and including it as a submodule to use @kfix's version of DDC. Awkward enough, I see @wagenet has already gotten this done albeit not using submodules.

I also think we should get rid of the compatibility chart. I do not know why I thought that was a good idea. Multiple people making PRs to update the README is a mess. Replacing the old ddc core with kfix's would also warrant a reset on the table.

francosolerio commented 7 years ago

New DDC breaks compatibility with LG 5K Ultrafine display / MacBook Pro 15 Touchbar.

Kalvin126 commented 7 years ago

So you are not able to use superduper's build? DDC compatibility is such an issue on Macs I feel. The tool, with the old CGDisplayIOServicePort with macOS 10.11 worked for my Dell U2515h and P2014h but after going to 10.12, it stopped working. With the new method to get the service port, only my U2515h works now ._.

Perhaps it should revert to CGDisplayIOServicePort if read/writes fail.

francosolerio commented 7 years ago

Exactly. Superduper current commit (f16fd62b) doesn't work. Older commit (781dde78) works perfectly.

kfix commented 7 years ago

I'm fine with ddcctl being vendored via submodule if actual debugging is done for incompatibility reports.

I'm not fine with "it doesn't work, please fix" complaints with absolutely no debug work done by the reporter. I can't test & debug hardware I don't have. I focus on the HW I have (access to) and that's what ddcctl/master branch reflects. If BrightnessMenulet vendors ddcctl, I will definitely turn disable GitHub Issues tab and only accept PRs.

@Kalvin126 if you revert to CGDisplayIOServicePort people will complain about compiler warnings and they will really complain when it is removed from CoreGraphics.

Kalvin126 commented 7 years ago

I understand. In my diff, you'll see I removed the chart and feedback chart. On a side note, its been four releases since its depreciation. I wonder when it really will be removed.