superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 239 forks source link

[SUBGRAPH WORKFLOWS] Use matrix for multi-vendor|network deployment #1856

Closed d10r closed 3 months ago

d10r commented 9 months ago

What

If deploying to multiple networks and/or vendors via GH workflow, a matrix (ideally 2-dimensional) is used to map each deployment (vendor & network) to a job

AC

How

The workflow https://github.com/superfluid-finance/protocol-monorepo/blob/dev/.github/workflows/handler.deploy-production-subgraphs.yml currently just forwards the job of iterating through "all" networks to https://github.com/superfluid-finance/protocol-monorepo/blob/dev/packages/subgraph/tasks/deploy.sh. That script contains then figures out what "all" means for the given vendor and iterates through them. We instead want to dynamically create a matrix of networks to be used if "all" networks are selected, and map the deployment step to a job for each. The dynamic part is needed in order to avoid having to maintain redundant mappings in the subgraph package and in a workflow file.

hellwolf commented 4 months ago

@mmd-afegbua is it still done; if not, it still worth doing?

mmd-afegbua commented 4 months ago

Implementation of this was de-priotized because of the switch to Goldsky as we needed to perfect how to deploy and promote new subgraphs there. I've done that, we can now start working on this.

mmd-afegbua commented 3 months ago

Pull request ready for review: https://github.com/superfluid-finance/protocol-monorepo/pull/2003