[SUBGRAPH] approval mapping

superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.

https://www.superfluid.finance

Other

875 stars 239 forks source link

[SUBGRAPH] approval mapping #1878

Closed 0xdavinchee closed 8 months ago

0xdavinchee commented 8 months ago

create ApprovalEvent when Approval event is emitted from a SuperToken contract.

closes #1834

kasparkallas commented 8 months ago

We use the same event entity for the ERC-20 Approval and the NFT Approval? Why not use another entity?

0xdavinchee commented 8 months ago

We use the same event entity for the ERC-20 Approval and the NFT Approval? Why not use another entity?

we can, no strong reason to use the same for both

kasparkallas commented 8 months ago

We use the same event entity for the ERC-20 Approval and the NFT Approval? Why not use another entity?

we can, no strong reason to use the same for both

we decided to re-use the event

hellwolf commented 8 months ago

test is broken

kasparkallas commented 8 months ago

test is broken

ah, it's the test that's currently supposed to fail, will ignore

hellwolf commented 8 months ago

ah, it's the test that's currently supposed to fail, will ignore

So we shall wait for the fix, from some future PR. Right?

kasparkallas commented 8 months ago

ah, it's the test that's currently supposed to fail, will ignore

So we shall wait for the fix, from some future PR. Right?

future PR, we're already working it

created a feature branch (2024-03-subgraph-gda-feature-branch) to merge all the latest updates/fixes we want to finally test and release together

github-actions[bot] commented 8 months ago

XKCD Comic Relif

Link: https://xkcd.com/1878