superfluid-finance / protocol-monorepo

Superfluid Protocol Monorepo: the specification, implementations, peripherals and development kits.
https://www.superfluid.finance
Other
875 stars 239 forks source link

[ETHEREUM-CONTRACTS] more realistic fUSDC #2023

Closed d10r closed 2 months ago

d10r commented 2 months ago
github-actions[bot] commented 2 months ago

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

d10r commented 2 months ago

permit support was already added in https://github.com/superfluid-finance/protocol-monorepo/pull/1664, is available on newer testnets

d10r commented 2 months ago

piggy-backed fix for non-silent verification failure (https://github.com/superfluid-finance/protocol-monorepo/issues/1654)

d10r commented 2 months ago

Note regarding permit: the latest version 2.2 of FiatToken (USDC) added a variant of permit where the signature is just one parameter instead of 3. This has become common, but is non-standard (not as specified in https://eips.ethereum.org/EIPS/eip-2612).

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.37%. Comparing base (3989df1) to head (d420092). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2023 +/- ## ======================================= Coverage 88.37% 88.37% ======================================= Files 111 111 Lines 7001 7001 Branches 964 964 ======================================= Hits 6187 6187 Misses 812 812 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/2023/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | Coverage Δ | | |---|---|---| | [ethereum-contracts](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/2023/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `94.51% <ø> (ø)` | | | [sdk-core](https://app.codecov.io/gh/superfluid-finance/protocol-monorepo/pull/2023/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance) | `88.37% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=superfluid-finance#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

d10r commented 2 months ago
  • I don't see the permit support?

    • Missing update of the changelog.

permit was already there, see comments. no changelog update because only internal tooling changed.

hellwolf commented 2 months ago

no changelog update because only internal tooling changed.

It is a change to the deploy-test-network flow, so adding a line in changelog wouldn't hurt for future reference.

github-actions[bot] commented 2 months ago

XKCD Comic Relif

Link: https://xkcd.com/2023 https://xkcd.com/2023