Closed d10r closed 2 months ago
Reminder to update the CHANGELOG.md for any of the modified packages in this PR.
permit support was already added in https://github.com/superfluid-finance/protocol-monorepo/pull/1664, is available on newer testnets
piggy-backed fix for non-silent verification failure (https://github.com/superfluid-finance/protocol-monorepo/issues/1654)
Note regarding permit: the latest version 2.2 of FiatToken
(USDC) added a variant of permit
where the signature is just one parameter instead of 3. This has become common, but is non-standard (not as specified in https://eips.ethereum.org/EIPS/eip-2612).
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.37%. Comparing base (
3989df1
) to head (d420092
). Report is 1 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I don't see the permit support?
- Missing update of the changelog.
permit was already there, see comments. no changelog update because only internal tooling changed.
no changelog update because only internal tooling changed.
It is a change to the deploy-test-network flow, so adding a line in changelog wouldn't hurt for future reference.
Link: https://xkcd.com/2023