superhero-com / superhero-wallet

Superhero is a multi-blockchain wallet to manage crypto assets and navigate the web3 and DeFi space. Currently supporting Bitcoin, Ethereum and æternity blockchains.
https://wallet.superhero.com
ISC License
40 stars 38 forks source link

ETH / BTC icon is displaying wrong in Tx details page #2579

Closed Liubov-crypto closed 10 months ago

Liubov-crypto commented 11 months ago

Describe the bug ETH / BTC icon is displaying wrong in Tx details page

To Reproduce Steps to reproduce the behavior:

  1. Open Tx details page
  2. Check ETH / BTC icon
  3. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Reproducible on ETH dev branch.

Image

Image

Liubov-crypto commented 10 months ago

I'm still seeing wrong BTC/ETH icons on eth dev branch, commit b182d50 :

https://github.com/superhero-com/superhero-wallet/assets/69896204/d87605ef-9c10-4971-91a3-bed4be217447

martinkaintas commented 10 months ago

I PR was not linked correctly, please check it here #2610

Liubov-crypto commented 10 months ago

Fixed, LGTM