search

superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

perf: use dryAeSdk to collect multisig info #2947

Closed CedrikNikita closed 5 months ago

CedrikNikita commented 5 months ago

fixing one part of the issue raised here https://github.com/superhero-com/superhero-wallet/blob/d233c480fcbc0a0ab1ddf79deda42b30d96495c5/src/protocols/aeternity/libs/AeSdkSuperhero.ts#L35 by simply using dryRunSdk that doesn't have accounts and will not call our overridden _resolveAccount method, every time we are updating multisig vaults info.

github-actions[bot] commented 5 months ago

Deployed to feature-use-dry-run-sdk-to-collect-multisig-info.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 5 months ago

Got v3 contracts issue: м3зк

github-actions[bot] commented 5 months ago

Deployed to feature-use-dry-run-sdk-to-collect-multisig-info.wallet.z52da5wt.xyz, artifacts

Liubov-crypto commented 5 months ago

In general LGTM. The issue with v3 contracts has been fixed.

I got an issue with pending multisig Tx displaying, but only once. I tried to reproduce it, but my attempts were not successful. Probably it worth to add it to our backlog...

steps to reproduce it:

  1. create multisig
  2. propose Tx from new multisig with 0 balance
  3. observe an issue:

errrm

https://github.com/superhero-com/superhero-wallet/assets/69896204/49c01b6f-4422-42a4-b343-626f736c137b