Closed peronczyk closed 2 months ago
WalletConnect feature
Acceptance criteria:
Wallet connect icon for the top bar:
WalletConnect modal with options to scan QR and input/paste URI link:
Prototype recording:
Design:
Not connected icon:
Connected icon:
Scan QR or use input URI:
Connecting:
Unable to connect:
Connected to dapp (disconnect?):
Figma Design Reference:
@smaroudasunicorn updated design after syncing with @peronczyk on Friday (26.04).
I am ok with updated Proposals
WalletConnect feature
@smaroudasunicorn updated design after syncing with @peronczyk. Design update after updated technical requirements:
Acceptance criteria:
Wallet connect icon for the top bar:
WalletConnect modal with options to scan QR and input/paste URI link:
Prototype recording:
Design:
Not connected icon:
Connected icon:
Scan QR or use input URI:
Connecting:
Unable to connect:
Connected to dapp modal (disconnect?):
Figma Design Reference:
@peronczyk
Following issues should be addressed:
! 5. Unknown connection error observed:
@onvisions this task can be reviewed now.
@peronczyk unfortunately there are still a lot of issues.
I am listing all issues I have found here and I will not make another review for a third time so @Liubov-crypto you may use these as reference later when testing.
Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=31920-201379&t=jVVanDpKsBSeZ9Yc-0
@peronczyk by the way, this is my mistake but let's update it for consistency. I already updated the Figma reference.
InfoBox
component was developed this way. We use it in several other places. I can change the alignment globally, provide the ability to left-align only for selected places or leaver it as it is. Which option should I choose?
This task needs some designs: https://github.com/superhero-com/superhero-wallet/issues/2664 - you can open the PR and use the deployed test version. Please use only the web (not the extension).
The demo app is available here: https://feat-eth-dapps-support.wallet.z52da5wt.xyz/
Here is the list of required elements & screens: