superhero-com / superhero-wallet

Superhero Wallet – More than just a way to receive, store & send tokens on the æternity blockchain
https://wallet.superhero.com
ISC License
39 stars 38 forks source link

Create an Address Book for Contacts #3036

Closed smaroudasunicorn closed 2 months ago

smaroudasunicorn commented 4 months ago

Address Book to be stored locally on Device. Import/Export functionality shall also be present.

onvisions commented 4 months ago

Address Book @smaroudasunicorn

1. Address book main screen (addresses list) mockups:

Image

Image

Image

Image

Image

Image

2. Address book single address record mockups:

Image

3. Address book Add address screen mockups: I was thinking if we can make the top part (with the QR code and account info) updated dynamically according to what's entered in the inputs below.

Image

Image

Image

  1. Select from Address book modal (Send funds flow): work in progress...

  2. Prototype recording: work in progress...

Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=31935-180432&t=gZlJbeKQFrjFsfqj-0

smaroudasunicorn commented 4 months ago

We want to be able to share my address to another address book

smaroudasunicorn commented 4 months ago

You need to be able to filter by name too

smaroudasunicorn commented 4 months ago

Add bookmark star next to all and have blockchains a bit separated in order to support more in the future.

onvisions commented 4 months ago

Address Book Design (updated after feedback 31.05) @smaroudasunicorn @martinkaintas

1. Address book main screen (addresses list) mockups:

Access Address book from the More screen. The "Address book" tab shows the number of address records:

Image

Addresses list, filters, show all, show bookmarked (favourites), filter by blockchain:

Image

Image

Image

Image

No records messages:

Image

Image

Image

Scrolled Address records list (Search by name or address is shown); Multiple filters future proof support (with horizontal scroll of the blockchain filters):

Image

2 Address book - single address record (Edit):

Image

Image

3. Address book - Add address record screen:

Image

Image

Image

Image

Errors:

Image

Image

4. Select address from Address Book modal (Send funds flow):

Image

Image

Select account address from address book modal:

Image

Image

Image

Image

Image

  1. Send funds using Address book prototype recording:

https://github.com/superhero-com/superhero-wallet/assets/12225410/a2b96955-fe12-4e49-9bbf-b78d5fcbdd0e

  1. Manage Address book prototype (filter records, add and remove record, add to "bookmarked"):

https://github.com/superhero-com/superhero-wallet/assets/12225410/8397bbc0-bffb-4812-8b3f-1a80c279ddfc

Figma reference: https://www.figma.com/design/3oGLWzSH0oJljo4RETZtur/Superhero-Wallet-UI-(%E2%9C%94%EF%B8%8FUpdated)?node-id=31935-180432&t=gZlJbeKQFrjFsfqj-0

onvisions commented 3 months ago

@martinkaintas @smaroudasunicorn Address book default ordering within the address records list.

Alphabetical, with numbers first:

1 Trading Uniswap 2John Doe Alf salary account .....................

Thus the user will have some control over the ordering of address book records in the list through custom naming.

Beyound the MVP we can think of functionality to reorder addresses/accounts in the list by dragging the list items up and down. This will be useful not only for address book but also for the account management as it may change the default order of the account cards in the switcher. IMO we should include it in some user stories for extended "Account management" and "Address book records management". These may also include batch actions such as remove/delete multiple accounts/address records.

smaroudasunicorn commented 3 months ago

a minor comment. Change add address button to add....

onvisions commented 3 months ago

a minor comment. Change add address button to add....

1 1 Address book - all

martinkaintas commented 3 months ago

Created a separate task for Address Book: Send to address book record #3104

Liubov-crypto commented 2 months ago

Found minor design discrepancies on this screen, please check it:

Image

Image

the rest is LGTM

martinkaintas commented 2 months ago
  • additional word "blockchain' in Address field

This is according to the design in Figma, @onvisions please lmk which one should be used

onvisions commented 2 months ago
Liubov-crypto commented 2 months ago

Now it looks better:

https://github.com/superhero-com/superhero-wallet/assets/69896204/509b6a9f-d85c-4a89-b5d4-64184f1fd89c

@onvisions what do you think about Bookmark?

onvisions commented 2 months ago
  1. @Liubov-crypto we have synced with Martin the new look of this button. Design reference is in Figma.

  2. For the character counter we have design reference:

image

However I noticed it has not been implemented in this way across the UI so if this is the case (@martinkaintas please confirm) I suggest to create a separate sotry for UX/UI improvement of the feature.

Liubov-crypto commented 2 months ago

LGTM