supermedium / beatsaver-viewer

⚔️ Web-based viewer for Beat Saver maps, built with A-Frame and JavaScript.
https://supermedium.com/beatsaver-viewer/?id=811-535&difficulty=Expert
MIT License
192 stars 32 forks source link

Add support for "&time=" URL parameter to open a map at specified time #19

Closed n3tman closed 5 years ago

n3tman commented 5 years ago

It would be super helpful to be able to create a link which opens a song at a given position. Mostly for doing beatmap reviews - pointing people to specified pattern or showing them their mistakes. Would be similar to &difficulty=ExpertPlus

Example - open a map at 3:40 position:

https://supermedium.com/beatsaver-viewer/?id=11645-12388&time=220

Also add a link: Copy map URL at current time

ngokevin commented 5 years ago

Thanks for filing all the issues, they are all legit.

n3tman commented 5 years ago

No worries, hope I don't ask for a lot. I would help myself if I knew Node.js better (and if you accept pull requests, of course).

Thanks so much for this amazing tool!

ngokevin commented 5 years ago

Yeah, pull requests accepted, also just plain JavaScript, not Node. But no worries!

ngokevin commented 5 years ago

Done! https://github.com/supermedium/beatsaver-viewer/commit/8187bad9ad297092bee0062eb8282af29d560b49