search

superphy / spfy

Spfy: an integrated graph database for real-time prediction of Escherichia coli phenotypes and downstream comparative analyses
https://lfz.corefacility.ca/superphy/grouch/
Apache License 2.0
4 stars 2 forks source link

Serotype and VF results cannot be separated #223

Closed mwhitesi closed 6 years ago

mwhitesi commented 7 years ago

If serotype and VF are both checked, but "group results" is unchecked, still get grouped results

kevinkle commented 7 years ago

A possible solution would be to run ECTyper always with only 1 option selected (VF or Serotype); right now, we group both together in ectyper's subprocess call and parse the outputs together (hence they group results).

Separating into two subprocess calls would prob. be a better approach as we can remove the atrocious number of if statements currently written in to do this.

Can consider this issue a subissue of https://github.com/superphy/backend/issues/221

mwhitesi commented 7 years ago

Agreed, i just wanted to make a note of this issue, so it gets addressed in the next release when the upload process is refactored.

We might consider changing the whole group data approach so different data is displayed on the same page but different tables in order to display distinct data types. Right now phylotyper results table is not the same as the subtyping table

kevinkle commented 6 years ago

Ended up with the opposite approach as of https://github.com/superphy/spfy/releases/tag/v6.2.0.

All results are merged into one table.