superscriptjs / superscript

A dialogue engine for creating chat bots
http://superscriptjs.com
MIT License
1.65k stars 209 forks source link

Limits Importer to removing Topic, Reply, Gambit data. Refs: #366 #369

Closed Lewwwk closed 7 years ago

Lewwwk commented 7 years ago

Description

As per #366, ImportData was removing users every time it was re-importing the scripts. As there is no need to do so and it could create catastrophic data loss in production scenarios, I've simply removed 'Users' from the removal process.

Motivation and Context

I also investigated the possibility of adding a 'collectionsToRemove' array in cleanup that could then inform the ImportData function, but didn't have a use case that warranted it.

How Has This Been Tested?

Poses no issues locally.

Types of changes

Checklist:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 80.554% when pulling c379517c552ec180d74613a1bb4de51a0797b788 on cleanup_update into 77327d1fef04ba9637ca15749083ddfab58d673c on master.

Lewwwk commented 7 years ago

👍