search

supertuxkart-sourceforge-migration / stk-migration-test

0 stars 0 forks source link

GamePadDevice class is leaking memory. #133

Closed supertuxkart-sourceforge-migration closed 10 years ago

supertuxkart-sourceforge-migration commented 10 years ago

Author: nathanm32292394

I found a small leak in the GamePadDevice class using Valgrind. It was creating 3 new objects, namely m_prevAxisDirections, m_prevAxisValue, and m_axis_ok, but was only deleting 2 of them. The attached patch solves this by assuring that m_axis_ok is deleted.

supertuxkart-sourceforge-migration commented 10 years ago

Author: nathanm32292394 I generated Valgrind logs using: valgrind --leak-check=full --log-file=valgrind7.log ./supertuxkart valgrind --leak-check=full --log-file=valgrind8.log ./supertuxkart

supertuxkart-sourceforge-migration commented 10 years ago

Author: nathanm32292394 This patch is for the supertuxkart.src package of openSUSE Linux 11.3. I downloaded this package from the "openSUSE BuildService - Games" repository located at http://download.opensuse.org/repositories/games/openSUSE_11.3/.

supertuxkart-sourceforge-migration commented 10 years ago

Author: auria Thanks for the patch, it was applied in SVN