search

suppergerrie2 / ModJam5

Minecraft mod for ModJam5
GNU General Public License v3.0
5 stars 4 forks source link

Mod version checker #23

Closed VirxEC closed 4 years ago

VirxEC commented 5 years ago

If you accept this, your mod will:

  1. Check if another version of this mod has been released, and notify the user.
  2. If the user chooses to, they will be direct to a download link for your mod. (I set it to your download page on CurseForge.)

Right now update.json is incomplete because idk what your changelog is.

All you have to do is change the version of your mod in Reference.java and update update.json (that file should be in the mod; should be on GitHub only) and then that's it! Your users will get a notification for your new version. Example? Download an old version of my mod at https://minecraft.curseforge.com/projects/rubies-mod then go in the game and next to mods you will see a green "emerald?" (idk what it is, Forge is weird), click on it, go to the mod, (should have the same symbol next to it) and you will see the changelog and update URL.

futilityteam commented 5 years ago

Looks promising. BTW is the accepted versions syntax correct?

suppergerrie2 commented 5 years ago

Did you test if the mod works in these versions? Idk if something changed or if the mod uses methods that are only in newer versions?

VirxEC commented 5 years ago

Fixed all recommendation please review again @suppergerrie2

VirxEC commented 5 years ago

Sorry for the latency but yes ur mod works in the versions, as they are extremely similar except for some bug fixes on Mojang's part @suppergerrie2

suppergerrie2 commented 5 years ago

I'm more worried about forge changes :D

VirxEC commented 5 years ago

I can remove it if you want

VirxEC commented 5 years ago

Fixed it @suppergerrie2 it now only runs in 1.12

suppergerrie2 commented 5 years ago

Was just saying why I asked if you had tested it. :P

VirxEC commented 5 years ago

No, but if you accept this (1.12 only) I will create another pull request later to update it to 1.12.1 and 1.12.2 and make sure that it works.

suppergerrie2 commented 5 years ago

You should probably set it to 1.12.2 ATM, because that is the version it is developed on.

VirxEC commented 5 years ago

got it

VirxEC commented 5 years ago

Done

VirxEC commented 5 years ago

@suppergerrie2 can confirm that ur mod doesn't work in 1.12.1 Forge; errors with EntityAIAttackRanged, EntityAISearchItems, EntityArcherDrone, RecipeFilterDrone, and ShapedDroneUpgradeRecipe. The 1.12.1 and 1.12 compatibility has been removed from this pull request, and will now only work in 1.12.2 Forge.

VirxEC commented 5 years ago

Can you please accept this pull request now?