search

supriya-project / uqbar

Tools for building documentation with Sphinx, Graphviz and LaTeX
https://supriya-project.github.io/uqbar
MIT License
13 stars 7 forks source link

Clarify uses and nonuses of staticmethods #80

Closed jgarte closed 1 year ago

jgarte commented 1 year ago

WDYT?

Should lines 56 and 147 just be standard methods instead of static methods?

Let me know if you'd like me to split this into two separate commits or if fine as is.

josiah-wolf-oberholtzer commented 1 year ago

This is a weird class, but leave it. The methods are actually used by Sphinx.

jgarte commented 1 year ago

Is there any docs that explain why sphinx wants the methods to be that way? I agree that it is confusing.

I had extraneous arguments in visit_block_html and visit_block_latex in this PR still. It should have been a function of no arity in my thinking.