surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.17k stars 400 forks source link

Consider End Binary Distro of LV2 #6605

Closed baconpaul closed 1 year ago

baconpaul commented 2 years ago

The LV2 with the community fork has several bugs. We keep getting reports like this:

Screen Shot 2022-09-10 at 11 01 01 AM

so lets stop the binary distribution of it at least, since it seems with juce 7 the community juce 6 fork is no longer actively maintained.

haenkel commented 2 years ago

Not enough time to create anything pullrequestworthy but I quickly tried something and thought I'd share it. If I do something like this: https://github.com/haenkel/surge/commit/899bacb54899ce9c5854c56fa300e5586a933261 then patches seem to (re)load correctly in all formats for me. (haven't tried ardour but same happens in reaper)

baconpaul commented 2 years ago

So that just forced things to load twice right?

haenkel commented 2 years ago

simplified the above example but yes it does that

dvzrv commented 2 years ago

so lets stop the binary distribution of it at least, since it seems with juce 7 the community juce 6 fork is no longer actively maintained.

JUCE 7 has native support for lv2 :)

baconpaul commented 2 years ago

Yes I know. It doesn't seem to work quite properly for us when we check in the hosts that support it; but also we are on juce 6 still!

baconpaul commented 2 years ago

or more accurately: a version of juce 6 with some accessibility patches which are critical so moving is a pain.

you can build surge today with juce 7 if you want and get an lv2. this is just about whether we should continue to ship a binary built with the community build.

mkruselj commented 2 years ago

JUCE 7 has native support for lv2 :)

Yep and LV2 produced by JUCE 7 doesn't work in Reaper, for example.

baconpaul commented 1 year ago

meh lets not change anything for 1.2

baconpaul commented 1 year ago

Done