surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)
https://surge-synthesizer.github.io/
GNU General Public License v3.0
3.14k stars 399 forks source link

Locale issue with typeins #7574

Open mkruselj opened 7 months ago

mkruselj commented 7 months ago

Miętus on Discord reports that our typeins show him decimal numbers with dot as decimal separator, but this text entry doesn't work properly (it truncates the decimal part). They have to use comma instead, which works, but also means they manually have to replace the dot every time typein shows up. They are using Polish locale on Windows.

For me, Croatian locale on Windows, it's the other way around. Dot works just fine but comma is not parsed and truncates the decimal part to 0.

baconpaul commented 3 months ago

It kinda matters which control does this.

But for this it's good enough to understand the pitch slider on an OSC and the mix slider on the Delay effect (they are two different code paths)

What do they display and parse?

It's hard for me to debug this on my mac, but i also only have en us utf8 on the mac. I can install some more on my windows image.