Amp envelope funny sustain behavior

surge-synthesizer / surge

Synthesizer plug-in (previously released as Vember Audio Surge)

https://surge-synthesizer.github.io/

GNU General Public License v3.0

3.01k stars 385 forks source link

Amp envelope funny sustain behavior #7686

Open jprykiel opened 4 days ago

jprykiel commented 4 days ago

Hi, I noticed that the amp envelope behaves funny in certain conditions. When sustain is at 0, Decay time below 13.3 ms and set to quadratic, a small residual and distorted sound can be heard. Here is an example patch. Cheers, JPR JPR sustain.zip

baconpaul commented 3 days ago

This is all related to the comment in the hi / lo section of the ADSR digital with the weird approach to bounding sustain by next which misses at sustain zero. See the comment there

The particular problem is fixed by setting the zero out put to 5e-3 rather than 1e-4 but then retests fail and i didn't investigate yet (over in #7684)