search

surrealdb / helm-charts

4 stars 5 forks source link

feat: support custom envs for pods #8

Closed hegerdes closed 1 month ago

hegerdes commented 5 months ago

About

This PR adds support to set custom envs to the deployed pod.

Why

Users may want to set extra envs for proxy setups, logging or other.
A special usecass is to supply credentials, such as the initial password in other ways then setting plain text credentials in the values file.
This allows users to reference existing secrets or configmaps.
This would also fix #1 and similar requirements

hegerdes commented 5 months ago

Hi, just wanted to check in. Are PRs welcome? Didn't find a contribution guide.

\cc @sgirones

sgirones commented 5 months ago

Definitely, thanks for the PR!

sgirones commented 5 months ago

You will need to bump the version of the Chart.yaml

hegerdes commented 5 months ago

You will need to bump the version of the Chart.yaml

Sure, can do this. What is your versioning schema? Bump to v0.4.0 or 0.3.4?

sgirones commented 5 months ago

let's do 0.3.4 for now. We need to put some more process and structure to this repo and settle on the versioning strategy, so we can align it with the SurrealDB releases.

hegerdes commented 3 months ago

We are going to release surrealdb on a new environment soon so I quickly wanted to check in what the state of the PR is. Is there a ETA for the next helm release with this included @sgirones ?

Not having to support our own helm chart for this would make a little easier.

hegerdes commented 1 month ago

Will there be an answer? I don't want to be rude but inviting people to contribute, but then ignore them for months does seem a little off. All while publishing a new major version of your product without ever touching the charts or providing an official change-log.

This is extrem strange behavior. I really would like to get this closed.

sgirones commented 1 month ago

hey @hegerdes, I'm really sorry about this. I got absorbed in internal stuff and missed the notifications on this.

We (I) really appreciate these contributions and we plan to improve how we handle them 🙏