search

suryanshsingh2001 / MyLibrary

MyLibrary 📚 is a modern library management web app built with React.js, 🔐 Auth0 for authentication, 📖 Google Books API for book data, and styled with 🎨 Tailwind CSS for a delightful user experience.
https://mylibrary01.vercel.app/
MIT License
25 stars 25 forks source link

improve Search Bar #36

Closed MokshagnaV closed 1 year ago

MokshagnaV commented 1 year ago

34 Improved Search bar

Used react-select package

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @suryanshsingh2001 on Vercel.

@suryanshsingh2001 first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mylibrary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 5:22am
MokshagnaV commented 1 year ago

PLease resolve these issues.

* [ ]   Books are not updating when clicked on suggestion bar.

* [ ]   Toastify error notifcation as soon as page loads.

* [ ]   Favicon Update not showing, , make sure to fetch the current changes made.

Sure, Sorry for that.

MokshagnaV commented 1 year ago

Done

MokshagnaV commented 1 year ago

Please resolve this issue

* [ ]  Books are still not updating when clicked on a suggestion.

* [ ]  Inaccurate suggestions.

Sorry for that. But it's working fine for me. Can you please check it again.

MokshagnaV commented 1 year ago

From the video i observed that all the searches are worked correctly. But Only for c++ the before search i.e., Hardy is remained. That means sometimes the data is not updating properly not always. Most of the time it works fine right? Even the current version of MyLibrary is also working same like that. I tried to do. But, I opened this issue is to just improve the UI of Search bar. Sorry i cannot work on it.

suryanshsingh2001 commented 1 year ago

@MokshagnaV Please resolve merge conflicts.

suryanshsingh2001 commented 1 year ago

From the video i observed that all the searches are worked correctly. But Only for c++ the before search i.e., Hardy is remained. That means sometimes the data is not updating properly not always. Most of the time it works fine right? Even the current version of MyLibrary is also working same like that. I tried to do. But, I opened this issue is to just improve the UI of Search bar. Sorry i cannot work on it.

No problem, I tested the app and this is already an issue with existing code. I'll resolve the issues and merge this PR as soon as you resolve these merge conflicts

MokshagnaV commented 1 year ago

From the video i observed that all the searches are worked correctly. But Only for c++ the before search i.e., Hardy is remained. That means sometimes the data is not updating properly not always. Most of the time it works fine right? Even the current version of MyLibrary is also working same like that. I tried to do. But, I opened this issue is to just improve the UI of Search bar. Sorry i cannot work on it.

No problem, I tested the app and this is already an issue with existing code. I'll resolve the issues and merge this PR as soon as you resolve these merge conflicts

Thank You I am resolving conflicts now