suse-edge / charts

SUSE Edge engineering Helm charts
https://suse-edge.github.io/charts/
Apache License 2.0
5 stars 18 forks source link

Upgrade BMO and address media issues #98

Closed Kristian-ZH closed 5 months ago

Kristian-ZH commented 5 months ago

This PR addresses the following things.

  1. Media Deployment is now enabled by default
  2. Media Ingress and SC are removed from the chart
  3. Media PVC is now configurable via the Values file
  4. Metal3 labels are improved:
    baremetal-operator-controller-manager-7bf86f5bff-9xwxv   2/2     Running   0          15m    app.kubernetes.io/component=baremetal-operator,app.kubernetes.io/instance=metal3,app.kubernetes.io/name=manger,control-plane=controller-manager,pod-template-hash=7bf86f5bff,webhook=metal3-io-v1alpha1-baremetalhost
    metal3-metal3-ironic-6df64c659c-9hffz                    4/4     Running   0          15m    app.kubernetes.io/component=ironic,app.kubernetes.io/instance=metal3,app.kubernetes.io/name=metal3-ironic,pod-template-hash=6df64c659c
    metal3-metal3-mariadb-6d85d8c4f8-vxbg6                   1/1     Running   0          15m    app.kubernetes.io/component=mariadb,app.kubernetes.io/instance=metal3,app.kubernetes.io/name=metal3-mariadb,pod-template-hash=6d85d8c4f8
    metal3-metal3-media-5cbbffd8c7-rl68w                     1/1     Running   0          15m    app.kubernetes.io/component=media,app.kubernetes.io/instance=metal3,app.kubernetes.io/name=metal3-media,pod-template-hash=5cbbffd8c7
  5. BMO version is upgraded to 0.5.1

The PR is tested in a local environment.

Resolves #90, resolves #91

hardys commented 5 months ago

lgtm but one reservation re enable_metal3_media_server changing default - that will make the default flow slightly easier, but we'll have to disable it for Sylva I think and in some other cases users may have existing solutions they wish to use instead - @ipetrov117 what are your thoughts, should we go ahead with this and adjust the Sylva values?