sussy-code / smov

Sudo-flix's source code (Allegedly)
https://docs.undi.rest
MIT License
802 stars 778 forks source link

Hold to edit bookmarks #79

Closed Pasithea0 closed 4 months ago

Pasithea0 commented 4 months ago

added the ability to hold to edit added floating button to finish

https://github.com/user-attachments/assets/e91111ae-e62e-4ce6-abe3-ba1cc4c37dff

Pasithea0 commented 4 months ago

https://main.envyflix.pages.dev/

Pasithea0 commented 4 months ago

Kinda bugged on mobile because of user selection. I think I can fix that easy, but don't merge yet

Pasithea0 commented 4 months ago

Ok that worked, it's good now. I also made the button have a green border so it's slightly easier to see. Honestly couldn't figure out how to get the theme accent color so green works.

https://main.envyflix.pages.dev/

ztpn commented 4 months ago

It's still broken on mobile. Here's a suggestion just scrap this old editing flow and use the bookmark button on mediaCard instead that also makes it more user friendly

Pasithea0 commented 4 months ago

It used to be like that but it was removed because it was too cluttered

ztpn commented 4 months ago

It used to be like that but it was removed because it was too cluttered

what? the bookmark button was never completed, on mw we had decided to replace the editing flow with bookmark button but before it could happen we got a c&d

Pasithea0 commented 4 months ago

I implemented it into sudoflix a while ago but BadDev didn't agree with how it looked. Screenshot 2024-07-27 at 10 33 51 AM

While I could have removed it completly, or the editing system as BadDev suggested, I implemented the solution: "searchQuery.length > 0" to show the bookmark button only when searching. This solution offers the best of both worlds for the user.

Here you can see it always enabled (as origonaly proposed), vs the change I made to only show it when searching. https://github.com/user-attachments/assets/7367340b-6052-4502-92a3-82c139a55c0c