suusan2go / kotlin-fill-class

Intellij plugin that provides intention action for empty constructor
https://plugins.jetbrains.com/plugin/10942-kotlin-fill-class
MIT License
268 stars 31 forks source link

[Request] Remove constructor extra line #123

Open dzmpr opened 1 year ago

dzmpr commented 1 year ago

Hi. Can you unify generation output for this two variants:

TestClass(<caret>)
// and
TestClass(
    <caret>
)

Second variant produces this output:

image

And it seems #120 broke trailing comma generation. As you can see at the picture above — comma was not generated.

oboenikui commented 1 year ago

@dzmpr Thank you for the report. I was able to reproduce the extra new line in my environment as well. As for the trailing comma, it seems to be working fine on my end. Could you please check if your settings have not been reset?

dzmpr commented 1 year ago

Oh, I get it. Plugin has its own setting to add or not trailing comma. Is it possible to respect the project/idea setting? I think it will be more convenient.

oboenikui commented 1 year ago

Thank you for your valuable input. Sorry, I had previously raised the issue of the location of the settings being confusing, but had not started on it yet. Like you, I did not know how to set it up before I became the maintainer and found it inconvenient. But the truth is, it is convenient to quickly switch settings as shown in this video. So I have no plans to change the location of the settings screen itself. As I raised in #96, I am now considering adding more means of knowing how to set it up.

Screen record 2023-08-21 22 45 17