Add seamonkey support.

[GoogleCodeExporter]

What steps will reproduce the option?
1. Change all instances of firefox2 to seamonkey in configure.ac
2. Execute autoreconf after step 1.
3. Run the configure script and install as normal.

What is the expected output? What do you see instead?
With the above changes the actual output is what I expect.

What version of the product are you using? On what operating system?
Seamonkey 1.1.X (ie. xulrunner 1.8.1.X)
Slackware 12.2

Please provide any additional information below.
This is not so much a defect as it is a additional option or enhancement. 
I use Slackware and it comes with the Seamonkey suite.  There is currently
no option for configure (or cmake) to find the seamonkey development files.
 I have built google-gadgets with Seamonkey support and it works great. 
Please add Seamonkey as an option to configure(.ac).

Original issue reported on code.google.com by larryh...@gmail.com on 10 May 2009 at 5:41

[GoogleCodeExporter]

seamonkey on my machine doesn't provide pkg-config file for libmozjs library, 
which
is mandatory for GGL. Does the seamonkey on your computer have it?

It's not feasible to just link against xpcom library, which will introduce too 
much
useless dependencies.

Original comment by james...@gmail.com on 12 May 2009 at 9:09

[GoogleCodeExporter]

Ok, here is what I have on my machine, and hopefully it answers your question.  

On a default full install of Slackware, the Seamonkey suite is installed.  
There are
6 pkg-config files that go with the Seamonkey package.  They are 
seamonkey-nss.pc,
seamonkey-js.pc, seamonkey-nspr.pc, seamonkey-xpcom.pc, 
seamonkey-gtkmozembed.pc, and
seamonkey-plugin.pc.

If an option for Seamonkey were added, and looking at the current configure.ac 
file
as a reference, then the 2 pkg-config files it would be looking for are
seamonkey-js.pc and seamonkey-gtkmozembed.pc.  Both of which are included and 
the
seamonkey-js.pc file is the one that contains the -lmozjs library.

Am I missing something?

Original comment by larryh...@gmail.com on 12 May 2009 at 2:42

[GoogleCodeExporter]

Interesting, which version is your seamonkey? Can you provide a patch to add the
support? As my seamonkey doesn't have these pc files, I can't verify it.

Original comment by james...@gmail.com on 12 May 2009 at 4:51

[GoogleCodeExporter]

I'm using the lastest stable version of Seamonkey (ie. 1.1.16).  I made a patch 
to
add support for Seamonkey.  It compiled fine, and while doing some very basic 
testing
with the gtk and qt versions, it seems stable and able to perform most of the 
tasks
that google-gadgets provides.

I'm supplying a patch that I made, per your your request, and I hope it makes 
it into
your software. :)  If you see something I missed in my patch then please let me 
know
and I can work on a new revision.

Original comment by larryh...@gmail.com on 12 May 2009 at 5:54

Attachments:

• seamonkey_support.diff

[GoogleCodeExporter]

Thanks very much for your patch. I'll look into it asap.

Original comment by james...@gmail.com on 13 May 2009 at 2:20

[GoogleCodeExporter]

It should have been fixed in trunk, please have a try.

Original comment by james...@gmail.com on 22 May 2009 at 2:55

[GoogleCodeExporter]

I was able to successfully build it from the latest svn.  I've only had limited
testing with the svn, so I'll report back if there are any issues.  Thank you 
for
adding seamonkey support.

I also noticed that you added seamonkey support in the cmake/Configure.cmake 
file.  I
also think that the appropriate line(s) should also be added to 
SpiderMonkey.cmake. 
I didn't include a patch for cmake as it still looks experimental and it fails 
during
compile time when seamonkey support is added.

Thank you.

Original comment by larryh...@gmail.com on 22 May 2009 at 4:36

[GoogleCodeExporter]

thanks for your feedback. what error did you encounter when trying cmake?

Original comment by james...@gmail.com on 22 May 2009 at 4:47

[GoogleCodeExporter]

Hmmm...weird.  I can't build against the 0.10.5 release but I can against the 
current
svn. :)  I guess its currently not an issue.

I'm adding a patch that I used against cmake/SpiderMonkey.cmake.  I can build
google-gadgets-for-linux with or without the patch.  So it may not actually do 
anything.

Original comment by larryh...@gmail.com on 22 May 2009 at 5:36

Attachments:

• seamonkey_cmake2.diff

[GoogleCodeExporter]

Fixed in trunk.

Original comment by james...@gmail.com on 24 May 2009 at 1:16

• Changed state: Fixed