search

svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

DagmcStats Refactor #82

Closed yqin43 closed 3 years ago

yqin43 commented 3 years ago

Description

DagmcStats -> DagmcFile (rename) Add DagmcQuery class init (separate file) Move get_tris() from DagmcFile to DagmcQuery

gonuke commented 3 years ago

It might be helpful to have a very short python script that shows how these classes will be used so that we make sure we have the same understanding.

kkiesling commented 3 years ago

It might be helpful to have a very short python script that shows how these classes will be used so that we make sure we have the same understanding.

a short script for us or users? If the former, there are notes in the shared document that show the workflow. If the latter, I think that should come in another PR that gives examples.

gonuke commented 3 years ago

It might be helpful to have a very short python script that shows how these classes will be used so that we make sure we have the same understanding.

a short script for us or users? If the former, there are notes in the shared document that show the workflow. If the latter, I think that should come in another PR that gives examples.

I as thinking of a minimal implementation for us.

kkiesling commented 3 years ago

It might be helpful to have a very short python script that shows how these classes will be used so that we make sure we have the same understanding.

a short script for us or users? If the former, there are notes in the shared document that show the workflow. If the latter, I think that should come in another PR that gives examples.

I as thinking of a minimal implementation for us.

Let's make a gist with the script..

kkiesling commented 3 years ago

It might be helpful to have a very short python script that shows how these classes will be used so that we make sure we have the same understanding.

a short script for us or users? If the former, there are notes in the shared document that show the workflow. If the latter, I think that should come in another PR that gives examples.

I as thinking of a minimal implementation for us.

Let's make a gist with the script..

NVM - it's not easy to collaborate on a gist it seems. We'll add this as a script in this repo.