svalinn / dagmc_stats

Tool for calculating and reporting statistics about DAGMC models
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Update get_triangles_per_surface for new design #92

Closed yqin43 closed 2 years ago

gonuke commented 2 years ago

How does this method fit into the new design? The current design already get all the triangles for all the surfaces in the meshset that is used to setup the DagmcQuery object. What's the use case that we are missing and how would it work?

gonuke commented 2 years ago

Maybe a related question... is this a method of DagmcFile or DagmcQuery in our current design?

yqin43 commented 2 years ago

How does this method fit into the new design? The current design already get all the triangles for all the surfaces in the meshset that is used to setup the DagmcQuery object. What's the use case that we are missing and how would it work? This function was in the original dagmc_stats.py file when I took over this work. It calculates the number of triangles of each surface instead of getting the triangles. I think it should be put into the DagmcQuery function.