search

svalinn / parastell

Parametric 3-D CAD modeling toolset for stellarator fusion devices
MIT License
26 stars 12 forks source link

Radial distance utility lightly broken by CadQuery magnets PR #149

Closed connoramoreno closed 1 month ago

connoramoreno commented 2 months ago

As foreseen by @Edgar-21, the radial distance utility does not work with the newest version of the magnet routine. I imagine and am hopeful that adapting radial_distance_utils.py and radial_build_distance_example.py won't be too difficult.

connoramoreno commented 2 months ago

Not sure if you wanted to take this on @Edgar-21? Or if you're too busy with other tasks, I can take a crack at it.

Edgar-21 commented 2 months ago

If you want to have at it, I likely won't get to it until later this week. If I recall correctly the main issue is some member variables changed names and maybe some methods got moved around? The problems should be localized to this function https://github.com/svalinn/parastell/blob/d768c7281a610c81d87bc5ae523cad62585c7212/parastell/radial_distance_utils.py#L104 Let me know if you start otherwise I'll get to it eventually