Closed AlKapkone closed 7 months ago
Did you test this against a real setup?
Tested locally and it's working as expected.
site24x7_monitor_latency_seconds{location="Amsterdam - NL",monitor_group="",monitor_name="example-api",monitor_type="RESTAPI"} 0.321
site24x7_monitor_latency_seconds{location="Amsterdam - NL",monitor_group="",monitor_name="example-front",monitor_type="URL"} 0.025
Unfortunately, the command curl https://accounts.zoho.eu/oauth/v2/token -X POST @curl-secrets
didn't work, so I used Postman for this purpose.
Error: curl: (6) Could not resolve host: curl-secrets
Postman usage:
Finished dev [unoptimized + debuginfo] target(s) in 0.22s
Running `target/debug/site24x7_exporter --site24x7-endpoint site24x7.eu`
14:02:20 [INFO] site24x7_exporter 1.0.1
14:02:20 [INFO] Using site24x7 endpoint: https://www.site24x7.eu/api
14:02:20 [INFO] Using Zoho endpoint: https://accounts.zoho.eu
14:02:20 [INFO] Not using any proxies
14:02:20 [INFO] Requesting access token from https://accounts.zoho.eu/oauth/v2/token
14:02:21 [INFO] Successfully acquired access token
14:02:26 [INFO] Serving metrics```
Could you rebase onto master please? That'll make the CI work.
Also please update the README and CHANGELOG.
"Could you rebase onto master please? That'll make the CI work." Should I merge my feature branch into the main branch of my fork?
You should fetch upstream/origin and rebase your feature branch on top of that so that the CI may run.
I got it, thanks, done. I missed that you made some fresh changes.
Also update the features section of the README.
And it would be great if you could rebase this down into one commit.
added support of REST API monitor type