sverrirs / jekyll-paginate-v2

Pagination Generator for Jekyll 3 (enhanced replacement for the old built-in jekyll-paginate gem) ⛺
https://rubygems.org/gems/jekyll-paginate-v2
MIT License
517 stars 285 forks source link

AutoPages collections need to be disabled manually to disable processing #228

Closed gouravkhunger closed 2 years ago

gouravkhunger commented 2 years ago

As suggested in Autopages documentation, I omitted collections from the configuration to disable building pages for them.

But it didn't omit them and still looked for the default autopage-collection.html file.

image

When I disable it manually then it works fine.

image

but tag configurations work fine if omitted. Maybe there's some problem in the code or the docs need to be updated?

MolotovCherry commented 2 years ago

Can confirm here it's by default enabled even though docs say to omit it to disable it

I guess it's clear enough once you see the defaults file https://github.com/sverrirs/jekyll-paginate-v2/blob/master/lib/jekyll-paginate-v2/autopages/defaults.rb

gouravkhunger commented 2 years ago

Yep, I had looked around the defaults file and got it fixed back then! Thanks for taking time to reply :)

MolotovCherry commented 2 years ago

Why are you closing this though? At the very worst, even if it's intended behavior (which I think it shouldn't be), the docs are wrong and it still needs fixing

gouravkhunger commented 2 years ago

The plugin isn't being maintained anymore, most issues and PRs are stale anyway 🤷🏻‍♂️