Closed massadm closed 3 years ago
Hi, I think this is fine.
https://github.com/symfony/polyfill-mbstring/blob/v1.19.0/composer.json#L19
This lib requires PHP 5.3 at the minimal version used in composer.json (1.19). So I think composer should be able to find a version of the lib to match PHP version (use older lib for older PHP, newer lib for newer PHP).
Do you have particular issue with dependency graph resolving (e. g. unable to build lock file with older PHP)?
Could you share your composer.json to reproduce the issue?
I think composer should be able to find a version of the lib to match PHP version (use older lib for older PHP, newer lib for newer PHP).
I see. composer require "swaggest/json-schema"
installing symfony/polyfill-mbstring
v1.19.0
under PHP 5.6.33 (cli)
and v1.23.1
under PHP 7.1.14 (cli)
. Something tells me that I'm not the only one who might stumble on this. :-)
Maybe you can help the issue by explicitly setting target PHP version like here: https://github.com/swaggest/php-json-schema/blob/v0.12.39/composer.json#L38.
Just
composer require "swaggest/json-schema"
for new project and got %subj%.Looked at what changed https://github.com/swaggest/php-json-schema/compare/v0.12.38...v0.12.39 and found out that added "Polyfill dependency for mbstring extension".
Do these directives in the
package.json
reflect your true intent?I'm asking because the requirements have changed significantly with introduction of
symfony/polyfill-mbstring
package.Thanks!