swaggest / rest

Web services with OpenAPI and JSON Schema done quick in Go
https://pkg.go.dev/github.com/swaggest/rest
MIT License
335 stars 17 forks source link

fix: allow 'application/json;charset=UTF-8' #162

Closed brianwilkinson closed 1 year ago

brianwilkinson commented 1 year ago

This is a regression - charset was allowed in versions prior to v0.2.50

vearutop commented 1 year ago

@brianwilkinson, out of curiosity, what is your setup that emits such content type (what kind/language/framework of client)?

Related to https://github.com/swaggest/rest/pull/158.

codecov[bot] commented 1 year ago

Codecov Report

Merging #162 (351a51c) into master (91e0f4f) will increase coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   77.98%   78.04%   +0.06%     
==========================================
  Files          28       28              
  Lines        1608     1608              
==========================================
+ Hits         1254     1255       +1     
+ Misses        233      232       -1     
  Partials      121      121              
Flag Coverage Δ
unittests 78.04% <100.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
request/jsonbody.go 100.00% <100.00%> (+2.70%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

brianwilkinson commented 1 year ago

Hi @vearutop. We have a suite of integration tests written in groovy/java that have all started to fail because of this change. I have not yet discovered if it is also a problem for our go client applications.

vearutop commented 1 year ago

Thank you for details. 👍

vearutop commented 1 year ago

The fix tagged with v0.2.51.