search

swandle06 / AopXml

1 stars 0 forks source link

Adding the current version validating the XML for the wiki #1

Closed swandle06 closed 4 years ago

swandle06 commented 4 years ago

I've replaced the xsd on this branch with the one we're using on the wiki. I know there was some back and forth between Ahmed and Genia leading up to the final release, but it doesn't look like the final files are in sync. Most of the changes seem to be with the minOccurs="0" constraint. I seem to recall some discussion about that, so I'm guessing it was causing a problem with the code we're using for validation even though it doesn't seem like that should hurt to include. It doesn't seem necessary though, wouldn't you agree?

I would assign Ahmed and Clemens for this one, but they haven't accepted the invitation yet, so we'll hold off for now unless Raif remembers anything about the last minute discussions with Genia 3 years ago.

rwasef1830 commented 4 years ago

I remember due to differences with one implementation being more lenient, we had to relax ours and make many elements optional (by setting minOccurs="0") in order for documents generated by that implementation to pass validation.

Alternatively, it might be due to handling of null vs not-null but empty collections (empty tag vs no tag). I can't remember more details than that.

swandle06 commented 4 years ago

@rwasef1830 Since Ahmed seems too busy, would you mind approving this request on his behalf? We can evaluate any changes needed to reverse changes you disagree with as long as they don't break the wiki validation. I'm pretty sure that was the source of the last minute changes, and I'm not sure why our validator didn't like the original representation.

swandle06 commented 4 years ago

@rwasef1830 The version associated with this pull request is the one currently used for AOP-Wiki validation. That why I need to get that as the official version before making additional changes. For whatever reason, it seems that the addition of the min_occcurs constraints actually caused validation issues on our end, and that's why Genia made those changes in the lead up to our last wiki release. We can try adding them back in the future, but our developer time is restricted at the moment, so my leaning would be to open an issue to re-evaluate in the future and merge this PR for now. Then I can make the edits required to eliminate our current validation errors, and we can revisit the other items when we have more bandwidth for addressing them. Does that work for you?

rwasef1830 commented 4 years ago

Ok by me, merge when convenient