search

swcarpentry / python-novice-inflammation

Programming with Python
http://swcarpentry.github.io/python-novice-inflammation/
Other
303 stars 781 forks source link

Update 11-debugging.md #1046

Closed minyoungJYi closed 1 year ago

minyoungJYi commented 1 year ago

The solution isn't consistent with the code in the question.

Doing this as a part of instructor checkout.

github-actions[bot] commented 1 year ago

:ok: Pre-flight checks passed :smiley:

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

edbennett commented 1 year ago

It's no longer obvious in the "blame" view because of the lesson transformation, but this change would effectively revert #991.

Since the lesson doesn't teach the % syntax for string interpolation at any point, I'd suggest that the solution not being changed was an oversight in #991, and it would be preferable to adjust the solution to match the exercise rather than the other way around.