search

swcarpentry / r-novice-gapminder

R for Reproducible Scientific Analysis
http://swcarpentry.github.io/r-novice-gapminder/
Other
164 stars 537 forks source link

Replace size with linewidth #890

Closed ndporter closed 5 months ago

ndporter commented 6 months ago

Replace size with linewidth for geom_smooth() example. Using size for lines was deprecated per this error message:

> ggplot(data=gapminder,
+        mapping=aes(x=gdpPercap,
+                    y=lifeExp)) +
+   geom_point(alpha=0.5) +
+   scale_x_log10() +
+   geom_smooth(method='lm', size=1.5)
`geom_smooth()` using formula = 'y ~ x'
Warning message:
Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.
ℹ Please use `linewidth` instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated.

Change throughout the lesson and additionally:

  1. Adjust language in explanations to match
  2. Add hint to challenge clarifying size is point equivalent of linewidth.
  3. Add some additional explanation of difference between aesthetics with vs without mappings.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review [the Contributing Guide](CONTRIBUTING.md) and [Code of Conduct](https://docs.carpentries.org/topic_folders/policies/code-of-conduct.html). Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.
github-actions[bot] commented 6 months ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-890

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md |    2 +-
 02-project-intro.md |    2 +-
 03-seeking-help.md  |    6 +-
 08-plot-ggplot2.md  |   23 +-
 config.yaml (gone)  |   95 -----
 md5sum.txt          |   50 +--
 renv.lock (gone)    | 1021 ---------------------------------------------------
 7 files changed, 37 insertions(+), 1162 deletions(-)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-05-16 13:15:02 +0000