swcarpentry / r-novice-inflammation

Programming with R
http://swcarpentry.github.io/r-novice-inflammation/
Other
161 stars 394 forks source link

Text on ln35, ep07 rmd. #565

Closed wccarleton closed 1 year ago

wccarleton commented 1 year ago

Hello Maintainers! As part of the instructor training checkout process, I've been reading carefully through the R lessons to see where any improvements could be made. Here's one from ln35 or episode 7 in the Programming with R lesson.

I think the previous text was slightly confusing because it gave instructions that would only make sense within RStudio without first specifying that they were meant to be followed in an RStudio session. There were also some awkward phrases that could lead to confusion even within an RStudio session, like "...click on the “Knit HTML” button at the top of the script...". In my Ubuntu version of RStudio, that option is in a dropdown menu accessible from the toolbar of the script window but it's not directly in the bar itself. The text could also lead people to look for a button inside the script rather than in the toolbar for the window containing the script. So, I've suggested some minor text edits with this PR.

zkamvar commented 1 year ago

I'm helping the current lesson Maintainers process outstanding pull requests on this repository, in preparation for transition to the new lesson infrastructure.

Thank you for this update @wccarleton! That little button at the top has changed over the years and I think your text works quite well!