Use isAvailable when reading simctl device JSON

swift-emacs / swift-mode

Emacs support for Apple's Swift programming language.

GNU General Public License v3.0

363 stars 47 forks source link

Use isAvailable when reading simctl device JSON #171

Closed woolsweater closed 3 years ago

woolsweater commented 3 years ago

swift-mode:debug-ios-app was failing because no simulator could be configured; the output of simctl was not as expected.

The availability field of the device object had been deprecated and was removed as of Xcode 11 (see https://developer.apple.com/documentation/xcode-release-notes/xcode-11-release-notes heading "Resolved Issues") in favor of a boolean isAvailable.

woolsweater commented 3 years ago

I'm not sure it's possible to add tests for this -- is the CI running on a Mac with Xcode installed?

taku0 commented 3 years ago

Thank you for your PR. It works fine.

The CI is configured only for Linux machines for now. It is technically possible to setup CI for macOS with iOS simulators because GitHub Action provides macOS images with Xcode.

woolsweater commented 3 years ago

Glad to be helpful! 🙂