[clang] Fix lifetimebound APINotes tests

swiftlang / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Swift’s stable releases of Clang as well as support the Swift project.

https://llvm.org

Other

1.12k stars 331 forks source link

[clang] Fix lifetimebound APINotes tests #9653

Open Xazax-hun opened 2 days ago

Xazax-hun commented 2 days ago

The APINotes implementation upstream and downstream are not exactly the same, this PR makes sure the lifetimebound type attribute for 'this' object is deduplicated, and updates the test to respect versioned attributes.

rdar://140295698

Xazax-hun commented 2 days ago

@swift-ci please test LLVM

Xazax-hun commented 1 day ago

I did not isolate the commit yet that causes the difference, but I don't think there is anything that would prevent us from doing that. It is more just the matter of allocating time for that.

Xazax-hun commented 1 day ago

I talked to @egorzhdan offline and the code changes make sense to upstream (PR opened: https://github.com/llvm/llvm-project/pull/117194). There is a smaller test-only change that make sense to do downstream for now, will update this PR.